Ebrehault listing block #7603
Ebrehault listing block #7603
Conversation
|
I changed the base branch to |
oops, sorry |
sneridagh
left a comment
sneridagh
left a comment
There was a problem hiding this comment.
@ebrehault sorry for taking so long to take a look!
It does look good for me so far!
Regarding the typings, I agree the current types are as baseline, we never have been exhaustive on defining them, and we are completing them "on the fly". I am not a TS expert at all, I would leave that to others that know more than me in that regard :)
| cli.getSite(), | ||
| ]); | ||
|
|
||
| const listingBlocks: { id: string; block: ListingBlockFormData }[] = |
There was a problem hiding this comment.
yes, this was the idea, however in the future we should have a generic "visitor" that executes specific extra calls if needed. Using an utilitity for that then call them all and execute them like the rootLoaderDataUtilities.
Naive implementation.
Comments:
apps/seven/app/root.tsx, not sure if that's accurateBlocksFormDatatype as followed:That way we can have a specific typing for each type of blocks instead of having one generic interface with a very unhelpful
[x: string]: unknown;.DummyBlockFormDatais there for now as the other specific block types are not existing yet, but it is meant to be removed once everything is properly typed.📚 Documentation preview 📚: https://plone-registry--7603.org.readthedocs.build/
📚 Documentation preview 📚: https://volto--7603.org.readthedocs.build/