Andrew/issue 383 fix hang #384
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
@ayjayt The pattern of always emitting a warning but silencing it under some circumstances feels backwards to me. Instead, could the |
|
Yeah in general i'm not 100% sure this is the Best API but the warning is only emited either way when the user is calling Open on an already opened instance or close on an already closed instance As for arguments, yes |
|
Right yes by "always" emit a warning I mean always emit when the server is already running. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #383
Adds missing argument that allows python to close without awaiting thread.
Also clarifies that the object is a singleton and it can only be started once. However, adds more functions to silence related warnings.
Also adds the atexit concept from mytien.