Skip to content

Commit

Permalink
Use old taskkill flags
Browse files Browse the repository at this point in the history
  • Loading branch information
ayjayt committed Jan 29, 2025
1 parent 4313b90 commit 5e87b7a
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion choreographer/utils/_kill.py
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
def kill(process: subprocess.Popen[bytes]) -> None:
if platform.system() == "Windows":
subprocess.call( # noqa: S603, false positive, input fine
["taskkill", "/IM", "/F", "/T", "/PID", str(process.pid)], # noqa: S607 windows full path...
["taskkill", "/F", "/T", "/PID", str(process.pid)], # noqa: S607 windows full path...
stderr=subprocess.DEVNULL,
stdout=subprocess.DEVNULL,
)
Expand Down
2 changes: 1 addition & 1 deletion tests/test_process.py
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@ async def test_watchdog(headless):
if platform.system() == "Windows":
# Blocking process here because it ensures the kill will occur rn
subprocess.call( # noqa: S603, ASYNC221 sanitize input, blocking process
["taskkill", "/IM", "/F", "/T", "/PID", str(browser.subprocess.pid)], # noqa: S607
["taskkill", "/F", "/T", "/PID", str(browser.subprocess.pid)], # noqa: S607
stderr=subprocess.DEVNULL,
stdout=subprocess.DEVNULL,
)
Expand Down

0 comments on commit 5e87b7a

Please sign in to comment.