Full test + version print

plotly · Dec 14, 2024 · a13399a · a13399a
1 parent 4bac997
commit a13399a
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 5 deletions.
diff --git a/.github/workflows/publish_testpypi.yml b/.github/workflows/publish_testpypi.yml
@@ -9,8 +9,8 @@ jobs:
   super-test:
     strategy:
       matrix:
-        os: [ubuntu-latest] #, windows-latest, macos-latest]
-        python_v: [3.09, ''] #, 3.10, 3.11, 3.12, 3.13]
+        os: [ubuntu-latest, windows-latest, macos-latest]
+        python_v: [3.09, 3.10, '']
         chrome_v: [0, -1]
     name: Build and Test
     runs-on: ${{ matrix.os }}
@@ -35,7 +35,7 @@ jobs:
       - run: uv sync --frozen --all-extras
       - run: git restore . # delete uv.lock changest
       - run: uv build
-      - run: uv run --no-sync choreo_get_browser --i ${{ matrix.chrome_v }}
+      - run: uv run --no-sync choreo_get_browser -v --i ${{ matrix.chrome_v }}
       - run: uv pip install dist/choreographer*.whl
       # should we delete choreographer?
 

diff --git a/choreographer/cli_utils.py b/choreographer/cli_utils.py
@@ -71,31 +71,44 @@ def get_browser_cli():
     parser.add_argument("--i", "-i", type=int, dest="i")
     parser.add_argument("--platform", dest="platform")
     parser.add_argument("--path", dest="path")  # TODO, unused
+    parser.add_argument(
+        "-v",
+        "--verbose",
+        dest="verbose",
+        action="store_true",
+    )  # TODO, unused
     parser.set_defaults(i=-1)
     parser.set_defaults(path=default_local_exe_path)
     parser.set_defaults(platform=chrome_platform_detected)
+    parser.set_defaults(verbose=False)
     parsed = parser.parse_args()
     i = parsed.i
     platform = parsed.platform
     path = parsed.path
+    verbose = parsed.verbose
     if not platform or platform not in platforms:
         raise RuntimeError(
             f"You must specify a platform: linux64, win32, win64, mac-x64, mac-arm64, not {platform}",
         )
-    print(get_browser_sync(platform, i, path))
+    print(get_browser_sync(platform=platform, i=i, path=path, verbose=verbose))
 
 
 def get_browser_sync(
     platform=chrome_platform_detected,
     i=-1,
     path=default_local_exe_path,
+    verbose=False,
 ):
     browser_list = json.loads(
         urllib.request.urlopen(
             "https://googlechromelabs.github.io/chrome-for-testing/known-good-versions-with-downloads.json",
         ).read(),
     )
-    chromium_sources = browser_list["versions"][i]["downloads"]["chrome"]
+    version_obj = browser_list["versions"][i]
+    if verbose:
+        print(version_obj["version"])
+        print(version_obj["revision"])
+    chromium_sources = version_obj["downloads"]["chrome"]
     url = None
     for src in chromium_sources:
         if src["platform"] == platform: