Andrew/connection restructure #23
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Esta PR es encima, despues de, andrew/revision_connection
Se cambia la estructura para hacer asi:
TODO:
Pal futuro:
Vamos a también crear funciones como:
open_tab()close_tab()open_session()close_session()create_target()close_target()se dependen de un read_jsons para funcionar, por que es una secuencia de comandas con "chrome".
Ahora mismo, con "print_read_jsons" tenemos una estrategia con un hilo.
Es debil y seria complejo hacerlo bien con condiciones de carrera.
Vamos a agregar otra estrategia: async/await, que va a permitir el usuario usar el paquete en forma concurente.
Tenemos que crear un tipo de send_command que devuelve un
Future(necesario para integrar on asyncawait). Y tenemos que crear otra version de "print_read_jsons" que usa el paquete de asyncawait con la version de hilo especial (que es compatible con asyncawait) y tambien resuelve losFuture.Despues de eso, eventos.
No seria este pull.