Neyberson/utils #24
Closed
Neyberson/utils #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ayjayt
requested changes
Sep 3, 2024
devtools/protocol.py
Outdated
| @@ -59,4 +59,55 @@ def run_print(debug): | |||
| thread_print = Thread(target=run_print, args=(debug,)) | |||
| thread_print.start() | |||
|
|
|||
| # we need to do something for errors | |||
| def verify_json_id(self, json_list, message_id, session_id=None, target_id=None): | |||
| for json_ in json_list: | |||
devtools/protocol.py
Outdated
| # we need to do something for errors | ||
| def verify_json_id(self, json_list, message_id, session_id=None, target_id=None): | ||
| for json_ in json_list: | ||
| if message_id in json_ and message_id == json["id"]: |
There was a problem hiding this comment.
que es json? no hay tal variable?
| return json_obj["result"]["targetId"] | ||
| else: | ||
| if "targetId" in json_obj["params"]: | ||
| return json_obj["params"]["targetId"] |
There was a problem hiding this comment.
hay un params en un json recibido?
ayjayt
requested changes
Sep 3, 2024
Comment on lines
+87
to
+91
| elif "result" in json_obj and "sessionId" in json_obj["result"]: | ||
| return json_obj["result"]["sessionId"] | ||
| else: | ||
| return json_obj["params"]["sessionId"] | ||
|
|
There was a problem hiding this comment.
este en un resultado o parte de un comando que enviamos?
Comment on lines
+92
to
+102
| def verify_json_list( | ||
| self, json_list, verify_function, verify_boolean=False, debug=False | ||
| ): | ||
| for json_ in json_list: | ||
| self.verify_json_error(json_) | ||
| verify_boolean = verify_function(json_) | ||
| if verify_boolean: | ||
| json_obj = json_ | ||
| if debug: | ||
| print(f">>>>>This is the json_obj: {json_obj}") | ||
| return json_obj |
Comment on lines
+104
to
+113
| def verify_json_error(self, json): | ||
| if "error" in json: | ||
| if "id" in json: | ||
| raise ValueError( | ||
| f"The command with id {json["id"]} raise an error. Error code: {json["error"]["code"]}. {json["error"]["message"]}" | ||
| ) | ||
| else: | ||
| raise ValueError( | ||
| f"Error code: {json["error"]["code"]}. {json["error"]["message"]}" | ||
| ) |
There was a problem hiding this comment.
todavia no leventamos errores, solo debe devolver la informacion sobre el error, supongo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.