Skip to content

Neyberson/close #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 127 commits into from
Sep 14, 2024
Merged

Neyberson/close #31

merged 127 commits into from
Sep 14, 2024

Conversation

ayjayt
Copy link
Collaborator

@ayjayt ayjayt commented Sep 9, 2024

nuevo

ayjayt and others added 30 commits September 5, 2024 14:44
@ayjayt
Targets now require browser:
7d70aa7 
To facilitate add_session
@ayjayt
Include result/error key with send_command future
2e22601
@ayjayt
Store headless in browser
cb3834b
@ayjayt
Store browser not protocol
9b06745
@ayjayt
Add create_tab create_session
7a4463a
@ayjayt
Add some testing
c0da518
@neyberson
Create close_session() in Target
f92ce2a
@neyberson
Add asyncio strategy in target.py:close_session()
3447220
@neyberson
Rename remove_session() to remove_tab() in browser.py
ce5bbc6
@neyberson
Create close_session() in browser.py
285ac78
@neyberson
Fix attributes and methods use in browser.py:close_session()
70c6ac3
@neyberson
Format code in browser.py
1562268
@neyberson
Rename some variables in target.py:close_session()
c2f70be
@neyberson
Rename close_session() to close_tab() and some variables in browser.py
bf858df
@neyberson
Change flatting to flatten in target.py:create_session()
56f2c57
@neyberson
Override create_session() in Browser
ec0957d
@neyberson
Add warning in browser.py:create_session()
32614cf
@neyberson
Change Tab to Target in isinstance
8eb068f
@neyberson
Detect error in json using key in close_session() and close_tab()
0032a62
@neyberson
Change parameter target to target_id in close_tab()
1fbeb14
@neyberson
Delete params in send_command() of browser.py:create_session()
18a30e2
@neyberson
Reorganize code in close_session() to delete Session instance
8140679
@neyberson
Reorganize code in close_tab() to delete instance
36a4c89
@neyberson
Create populate_targets() in browser.py
4457a39
@neyberson
Add conditional to identify page type in populate_targets()
a9a11ba
@neyberson
Add conditional to identify save targets
0fd4de2
@neyberson
Improve return with conditionals in populate_targets()
7a44d4b
@neyberson
Update app.py
2bf3fd8
@ayjayt
Organize an annotate a bit with comments
58ff690
@ayjayt
Replace return in populate() w/ method to get tab
8346c94
ayjayt and others added 28 commits September 13, 2024 12:57
@ayjayt
Add self to pipe.close()
0a2eea2
@neyberson
Add debug after unsubscribe sub_key in run_read_loop()
92335a5
@neyberson
Add print and conditional for invalid key of subscription
c5371c6
@ayjayt
Reorg app.py to mark exit from context
a9fab11
@ayjayt
Add {bye}\n for windows to pipe.close
d67b3d0
@ayjayt
Remove debug print
e18ed3c
@neyberson
Use list for subscriptions keys to avoid issues
e85c968
@ayjayt
Clean up debugs
d4c8ccf
@ayjayt
Add ERRATA documentation
9018a10
@ayjayt
Change trivially app.py
780ec97
@ayjayt
Print error w/ warning
dae0c5f
@ayjayt
Add note for TODO about temp dir
275dc29
@neyberson
Clean up debugs in protocol.py:run_read_loop()
c007121
@neyberson
Improve debugs and format in protocol.py:run_read_loop()
7e2b640
@neyberson
Merge branch 'neyberson/close' into neyberson/events
c49d507
@ayjayt
Add notes in errata
1135687
@ayjayt
Ignore file not found in temp dir deletion
f59bf26
@ayjayt
Improve debugs
7ddfddb
@ayjayt
Update ERRATA
3db7ea4
@ayjayt
Enable all in app.py
f8b12de
@ayjayt
Begin commenting ungracefulness
66946d5
@ayjayt
Lint for bare except
293796f
@neyberson
Merge branch 'neyberson/close' into neyberson/events
68b1f0c
@neyberson
Merge branch 'neyberson/close' into neyberson/events
1af8444
@neyberson
Delete imports in session.py
808f97d
@ayjayt
Clean up debugs
686a32b
@ayjayt
Lint typos
1f8c60e
@ayjayt
Merge pull request #32 from geopozo/neyberson/events
04b6c0a 
Neyberson/events
@ayjayt ayjayt merged commit 8fea4f6 into andrew/async-io Sep 14, 2024
1 check passed
@ayjayt ayjayt deleted the neyberson/close branch September 14, 2024 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ayjayt @neyberson