Skip to content

Andrew/process control #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 28 commits into from
Sep 23, 2024
Merged

Andrew/process control #36

merged 28 commits into from
Sep 23, 2024

Conversation

ayjayt
Copy link
Collaborator

@ayjayt ayjayt commented Sep 16, 2024

Must check on linux

ayjayt and others added 27 commits September 14, 2024 13:31
This involved some variable name changes.
Also aenter and aexit were created for async with
In general, it meant moving things out of protocol
Best solution yet, not best in general.
This means changes to open and close, splitting them into separate
functions. Closing all tabs also closes the browser, so async close
now checks to see if there are no tabs.

However, this now means async context leave doesn't work...
Should probably have separate kill function, pipe + command + 0 tabs?
Before kill.
Pipe close also after kill.
@ayjayt
Copy link
Collaborator Author

ayjayt commented Sep 19, 2024

Ignore or fix linter errors? Not a huge fan of that rule, especially in this case where we're just doing lots of try/fail

@ayjayt ayjayt merged commit ff9f91f into main Sep 23, 2024
1 check passed
@ayjayt ayjayt deleted the andrew/process_control branch September 23, 2024 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants