-
Notifications
You must be signed in to change notification settings - Fork 5
Andrew/process control #36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
+484
−237
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This involved some variable name changes. Also aenter and aexit were created for async with In general, it meant moving things out of protocol Best solution yet, not best in general.
This means changes to open and close, splitting them into separate functions. Closing all tabs also closes the browser, so async close now checks to see if there are no tabs. However, this now means async context leave doesn't work...
Should probably have separate kill function, pipe + command + 0 tabs? Before kill. Pipe close also after kill.
Ignore or fix linter errors? Not a huge fan of that rule, especially in this case where we're just doing lots of try/fail |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Must check on linux