Skip to content

Do tempdirs in vers dependent manner #89

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Sep 27, 2024
Merged

Do tempdirs in vers dependent manner #89

merged 8 commits into from
Sep 27, 2024

Conversation

ayjayt
Copy link
Collaborator

@ayjayt ayjayt commented Sep 27, 2024

No description provided.

@ayjayt
Copy link
Collaborator Author

ayjayt commented Sep 27, 2024

@neyberson leelo porfa

Fixes windows,

I get warnings on my machine, might be due to chromium version, but will likely be addressed, or is better address, after close_refactor

  1. do this
  2. do close_refactor PR
  3. do default_paths + which_windows PR
  4. test on local

@ayjayt ayjayt requested a review from neyberson September 27, 2024 16:37
@ayjayt ayjayt mentioned this pull request Sep 27, 2024
Closed
@ayjayt ayjayt merged commit c7d81fd into main Sep 27, 2024
3 of 4 checks passed
@ayjayt ayjayt deleted the andrew/version_guard_tempdir branch September 27, 2024 17:43
@ayjayt
Copy link
Collaborator Author

ayjayt commented Sep 27, 2024

resolved #88

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neyberson neyberson Awaiting requested review from neyberson

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ayjayt