Andrew/which windows #93
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ayjayt
commented
Sep 27, 2024
There was a problem hiding this comment.
siempre chrome_wrapper necesita un BROWSER_PATH
|
@neyberson comentarios porfa |
neyberson
reviewed
Sep 27, 2024
| if path and _is_exe(path): | ||
| return path | ||
| default_path = [] | ||
| if executable_name == chrome: |
There was a problem hiding this comment.
Aquí se podría dar un aviso de que el executable_name no está registrado en nuestras opciones? para mostrar qué opciones hay disponibles por si el usuario quiere jugar con la API
There was a problem hiding this comment.
we have to try and predict the name of the executable, we use a path-search function (which) with a list of common names. in this case, if none of that works, we try a list of the most common hard paths.
the user can always change the path with BROWSER_PATH env var, or with path= argument
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.