Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stripping Input Data from Background Callback Polling #3113

Open
wants to merge 10 commits into
base: dev
Choose a base branch
from
Open

Stripping Input Data from Background Callback Polling #3113

Changes from 6 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
e5d7249
attempting to make polling requests not eat bandwidth
Dec 30, 2024
4059c3e
Allowing state to have a fallback of `[]`
Dec 30, 2024
9c25455
fixing for lint
Dec 30, 2024
e2c3bac
swapping for camelCase
Jan 6, 2025
4d25329
fixing last camelCase
Jan 6, 2025
4b67283
fixing other errors
Jan 6, 2025
214a798
updating changelog
Jan 7, 2025
701cd68
touch to rerun tests
Jan 8, 2025
f17a71d
Merge remote-tracking branch 'remote/dev' into strip-background-polls
BSd3v Feb 3, 2025
d3f6868
Merge branch 'dev' into strip-background-polls
T4rk1n Feb 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 15 additions & 6 deletions dash/dash-renderer/src/actions/callbacks.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -439,6 +439,7 @@ function handleServerside(
const fetchCallback = () => {
const headers = getCSRFHeader() as any;
let url = `${urlBase(config)}_dash-update-component`;
let newBody = body;

const addArg = (name: string, value: string) => {
let delim = '?';
Expand All @@ -447,11 +448,19 @@ function handleServerside(
}
url = `${url}${delim}${name}=${value}`;
};
if (cacheKey) {
addArg('cacheKey', cacheKey);
}
if (job) {
addArg('job', job);
if (cacheKey || job) {
if (cacheKey) addArg('cacheKey', cacheKey);
if (job) addArg('job', job);

// clear inputs as background callback doesnt need inputs, just verify for context
const tmpBody = JSON.parse(newBody);
for (let i = 0; i < tmpBody.inputs.length; i++) {
tmpBody.inputs[i]['value'] = null;
}
for (let i = 0; i < (tmpBody?.state || []).length; i++) {
tmpBody.state[i]['value'] = null;
}
newBody = JSON.stringify(tmpBody);
}

if (moreArgs) {
Expand All @@ -464,7 +473,7 @@ function handleServerside(
mergeDeepRight(config.fetch, {
method: 'POST',
headers,
body
body: newBody
})
);
};
Expand Down