Refactor title and subtitle selection in drawMainTitle function to use scoped selector #7522
+51
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e context-specific selection from the graph div (gd).
emilykl
reviewed
Aug 15, 2025
test/jasmine/tests/titles_test.js
Outdated
|
|
||
| it('computes title automargins independently when multiple plots exist', function(done) { | ||
| var gd1 = gd; | ||
| var gd2 = createShadowGraphDiv(); |
There was a problem hiding this comment.
createShadowGraphDiv() is a specialized function for testing graphs in the shadow DOM; I'd rather not use it here.
Instead let's modify the createGraphDiv() function to accept an optional divId argument.
There was a problem hiding this comment.
PR is updated! I included a cleanup to destroy the new graph div after the test. Let me know if you'd prefer I update destroyGraphDiv to handle other IDs instead.
emilykl
requested changes
Aug 15, 2025
There was a problem hiding this comment.
See one comment regarding the test; otherwise looks great. Thanks very much for the fix @davibarbosa2 . 🎉
…ter and update tests to utilize the new functionality.
|
I'm seeing a CI failure 😢 the tests are passing on my machine. Any chance you could restart the build for me? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request refactors the
drawMainTitlefunction to improve how main titles and subtitles are selected.Previously, the function used a global
d3.selectAllto select the.gtitleand.gtitle-subtitleelements. This could lead to incorrect selections if multiple plots were present on the same page.The changes in this PR modify the selection to be context-specific by using
d3.select(gd).selectAll, ensuring that the title and subtitle elements are selected only from within the current graph div (gd). This prevents styling and layout conflicts between different plots.Closes #7521