-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Kaleido v1 in Plotly.py #5062
Open
emilykl
wants to merge
38
commits into
main
Choose a base branch
from
upgrade-kaleido
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
Show all changes
38 commits
Select commit
Hold shift + click to select a range
f0a78a6
small io refactor to support kaleido v1
emilykl a681c84
update kaleido tests to support kaleido v1
emilykl a7a6f24
Merge branch 'main' into upgrade-kaleido
emilykl 2e9c8af
update test requirements
emilykl 60bb748
simplify to_image
emilykl b87f752
use k.calc_fig() instead of k.write_fig() in pio.full_figure_for_deve…
emilykl e203623
merge main
emilykl 8054331
merge main
emilykl 1a195a7
add ci job to test with kaleido v1
emilykl 577d3ca
remove -y option
emilykl 89209ad
run test_kaleido instead of test_io
emilykl 96bf9a0
re-add orca, add deprecation warnings for orca and kaleido-v0 (exact …
emilykl 350dd48
error message for 'eps' with kaleido v1
emilykl 08c1d4e
pin kaleido v1 (prerelease) in test requirements
emilykl 8b47a0a
format
emilykl 249cc9f
deprecation warning wording
emilykl ad9dbd9
fix if/else for when engine not specified
emilykl e75a5df
add flow and endpoint for installing chrome via plotly
emilykl a2b4f3c
add write_images and to_images functions (not yet using shared Kaleid…
emilykl 2549299
format
emilykl ab3b700
fix test_image_renderer() test to work with both kaleido v0 and v1
emilykl de473e1
support pos args in to_images and write_images; rename plotly_install…
emilykl 71696fe
mising pos args in write_images()
emilykl 100b955
add tests for write_images() and to_images()
emilykl 5541a79
add new API for setting image generation defaults
emilykl 95a05db
format
emilykl 0a73d0e
Merge branch 'main' into upgrade-kaleido
emilykl 4d3dd56
install kaleido 1.0.0rc11 from PyPI
emilykl d871e74
remove extra import
emilykl b3e8d36
add [kaleido] install extra to pyproject.toml to help with installing…
emilykl ef5f520
fix deprecation warnings
emilykl 611e2e4
Merge branch 'main' into upgrade-kaleido
emilykl c92a1ee
small updates to deprecation warning text
emilykl b56d5ec
Merge branch 'upgrade-kaleido' of https://github.com/plotly/plotly.py…
emilykl c01cb8a
add missing changelog entries
emilykl bcd40f3
update changelog for 6.1.0b0
emilykl 54985b8
update pyproject.toml for 6.1.0b0
emilykl b4af0d5
Merge pull request #5121 from plotly/release-6.1.0b0
emilykl File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -117,6 +117,35 @@ commands: | |
source .venv/bin/activate | ||
python -m pytest -x test_init/test_lazy_imports.py | ||
|
||
test_io_kaleido_v1: | ||
steps: | ||
- checkout | ||
- browser-tools/install-chrome | ||
- browser-tools/install-chromedriver | ||
- run: | ||
name: Install dependencies | ||
command: | | ||
curl -LsSf https://astral.sh/uv/install.sh | sh | ||
uv venv | ||
source .venv/bin/activate | ||
uv pip install . | ||
uv pip install -r ./test_requirements/requirements_optional.txt | ||
# Install Kaleido v1 instead of the default version | ||
uv pip uninstall -y kaleido | ||
uv pip install 'git+https://github.com/plotly/[email protected]#subdirectory=src/py' | ||
- run: | ||
name: List installed packages and python version | ||
command: | | ||
source .venv/bin/activate | ||
uv pip list | ||
python --version | ||
- run: | ||
name: Test plotly.io with Kaleido v1 | ||
command: | | ||
source .venv/bin/activate | ||
python -m pytest tests/test_io | ||
no_output_timeout: 20m | ||
|
||
jobs: | ||
check-code-formatting: | ||
docker: | ||
|
@@ -166,6 +195,17 @@ jobs: | |
pandas_version: <<parameters.pandas_version>> | ||
numpy_version: <<parameters.numpy_version>> | ||
|
||
test_kaleido_v1: | ||
parameters: | ||
python_version: | ||
default: "3.12" | ||
type: string | ||
executor: | ||
name: docker-container | ||
python_version: <<parameters.python_version>> | ||
steps: | ||
- test_io_kaleido_v1 | ||
|
||
# Percy | ||
python_311_percy: | ||
docker: | ||
|
@@ -448,5 +488,10 @@ workflows: | |
python_version: "3.9" | ||
pandas_version: "1.2.4" | ||
numpy_version: "1.26.4" | ||
- test_kaleido_v1: | ||
matrix: | ||
parameters: | ||
python_version: | ||
- "3.12" | ||
- python_311_percy | ||
- build-doc |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
uv pip install kaleido>=1.0.0 || uv pip install 'git+https://github.com/plotly/Kaleido.git@latest-tag#subdirectory=src/py'
is my recommendationThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 I'll just update the CI manually once Kaleido 1.0.0 full version is on PyPI.