Add custom node type typing and expose state modification functions for custom nodes in Sankey diagrams #2641
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ons for custom nodes
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces two key enhancements to the Nivo Sankey component:
Custom Node Type Typing: Added type definitions for custom node types, providing better type safety and developer experience when customizing nodes.
State Exposure for Custom Nodes: Exposed useful state and state modification functions to custom nodes, allowing for more dynamic and interactive visualizations. This change enables developers to easily manipulate node states, such as highlighting or toggling, directly from custom node implementations.
These features aim to provide greater flexibility and control when working with Sankey diagrams in Nivo, improving the overall customization and interactivity of the visualizations.