fix(line): include lodash in dependencies #2785
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lodash is imported in packages/line/src/hooks.ts (as 'lodash/uniqueId.js') but was not included in line's dependencies.
|
@blx is attempting to deploy a commit to the plouc's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
This pull request has been automatically marked as stale. If this pull request is still relevant, please leave any comment (for example, "bump"), and we'll keep it open. We are sorry that we haven't been able to prioritize reviewing it yet. Your contribution is very much appreciated. |
Author
|
bump |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lodash is imported in packages/line/src/hooks.ts (as 'lodash/uniqueId.js') but was not included in
line's dependencies.Other packages within nivo, like
barorannotations, also import from lodash, but they already include lodash in their deps.Without this fix, I can't import the ResponsiveLine component in the nextjs project I'm working on (which already depends on lodash from elsewhere, but is not happy for
@nivo/lineto try to import lodash without declaring it as a dep).