Add open_timeout kwarg to exec_command() #147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ploxiln
reviewed
Dec 30, 2022
|
fixes #146 Minor note for the future: I know lots of projects tell you to open an issue then open a PR, but I prefer to keep things tidier by just opening the PR and putting the context and details in the PR. If the PR ends up being replaced by another PR that refers to it, that's fine. |
If non-None value is passed in, it's used when opening a new ssh channel. If value is None, value of 'timeout' kwarg is used.
harixxxx
force-pushed
the
open_channel_timeout
branch
from
5d01b3b
to
9bf4414
Compare
ploxiln
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If non-None value is passed in, it's used when opening a new ssh channel. If value is None, value of 'timeout' kwarg is used.