Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better support for AJAX comments #564

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Zodiac1978
Copy link
Member

Ongoing fixes for better AJAX comments support

See: https://wpdirectory.net/search/01HJKQW4Q7NCTKNB3W54CPARMZ

TODO: #149 (comment)

Fixes #149

Copy link

sonarcloud bot commented Feb 3, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@stklcode
Copy link
Contributor

stklcode commented Mar 6, 2024

This looks good to me, so I tend to merge it as is.

I'm not too deep into the inner logic right now, but I do not see this doing harm either, so one step into the right direction.

@Zodiac1978 Zodiac1978 added this to the 2.11.6 milestone Mar 10, 2024
@Zodiac1978
Copy link
Member Author

This is the first step to fix #149

There is another fix needed.
#149 (comment)

But it would help to avoid unnecessary code execution for AJAX calls - but as this wouldn't make much sense without fixing the above this PR could wait until we fix the other problem.

@Zodiac1978 Zodiac1978 modified the milestones: 2.11.6, 2.12.0 Mar 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow creation of comment form via ajax
2 participants