add "?amp" instead of "/amp/" for AMP visit tracking (#183)

pluginkollektiv · Jul 19, 2021 · 01458e8 · 01458e8
1 parent c49ff94
commit 01458e8
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 3 deletions.
diff --git a/inc/class-statify-frontend.php b/inc/class-statify-frontend.php
@@ -163,7 +163,7 @@ private static function make_amp_config() {
 			),
 			'extraUrlParams' => array(
 				'referrer' => '${documentReferrer}',
-				'target'   => '${canonicalPath}amp/',
+				'target'   => '${canonicalPath}?amp',
 			),
 			'triggers'       => array(
 				'trackPageview' => array(

diff --git a/inc/class-statify.php b/inc/class-statify.php
@@ -135,9 +135,15 @@ protected static function track( $referrer, $target ) {
 		/* Global vars */
 		global $wp_rewrite;
 
-		// Trim target URL.
+		// Trim target URL, i.e. remove query parameters..
 		if ( $wp_rewrite->permalink_structure ) {
-			$target = wp_parse_url( $target, PHP_URL_PATH );
+			$parsed_target = wp_parse_url( $target );
+			$target = isset( $parsed_target['path'] ) ? $parsed_target['path'] : null;
+
+			// Re-add AMP parameter to preserve that information (only applicable for JS tracking).
+			if ( isset( $parsed_target['query'] ) && 'amp/' === $parsed_target['query'] ) {
+				add_query_arg( 'amp', '', $target );
+			}
 		}
 
 		// Init rows.