fix: remove artificial error raising in /ping endpoint causing 500 errors and alert firing #25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rors and alert firing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The /ping endpoint in the FastAPI application is currently raising an exception every third second, which causes about 33% of the requests to fail with HTTP 500 errors. This triggers an alert in the boot-prod cluster for the flow-test workload.
Changes Made
Exception("unknown internal error")based on the current time modulo 3.{ "pong": True }.Rationale
The previous behavior was likely a testing artifact accidentally deployed in production causing a significant error rate and alert firing. This change ensures the /ping endpoint reliably returns success, stopping the alert from firing.
Please deploy this fix promptly to boot-prod to resolve the current alert issue.