fix: remove intentional exception in /ping endpoint to prevent 500 errors #32
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This PR removes the deliberately thrown exception in the
/pingendpoint that caused about one-third of requests to fail with 500 Internal Server Errors. This fix ensures that the endpoint always returns a successful response.Changes Made:
if int(time.time()) % 3 == 0: raise Exception("unknown internal error")block from the/pinghandler inapp/main.py.Rationale:
The intentional exception was likely introduced for testing but is causing elevated error rates in production, triggering alerts and disrupting health checks. This change restores reliable behavior of the
/pingendpoint without modifying other functionality.After merging, rebuild and redeploy the container for the flow-test service in the boot-prod cluster to resolve the alert and prevent further unnecessary failures.