fix: remove intentional exception in /ping endpoint to prevent 500 errors #34
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
The current
/pingendpoint raises an intentional exception approximately one-third of the time, causing 500 Internal Server Errors and triggering alerts for high error rates. This PR removes the intentional exception to make/pingreliably respond with success.Changes Made:
/pingendpoint inapp/main.py.Rationale:
This change ensures the
/pingendpoint, typically used for Kubernetes health checks, always returns a successful response. This will prevent spurious 500 errors, keep the alert from firing, and improve service reliability.After merging, the updated service should be redeployed to clear the alert.