fix: remove deliberate exception causing intermittent 500 errors on /ping endpoint #35
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR addresses the intermittent 500 Internal Server Errors observed on the
/pingendpoint in theflow-testworkload deployed in theboot-prodEKS Kubernetes cluster. The root cause was a deliberate exception raised every 3 seconds in the application code, causing unhealthy error rates and firing alerts.Changes Made
/pingendpoint inapp/main.pyto always return a successful response.Rationale
This removal prevents artificial failures that were likely leftover debugging or test code that mistakenly remained active in production. The fix should stop the intermittent 500 errors and reduce the alert noise.
After merging, redeploy the service and monitor error rates to confirm the resolution of the alert.