Guard intentional /ping errors with environment flag to fix 5xx alert #41
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This PR fixes the firing alert due to high HTTP 500 errors on the /ping endpoint caused by intentional exception raising every third second.
Changes Made:
ENABLE_PING_ERRORSto guard the intentional exceptions in the /ping endpoint.ENABLE_PING_ERRORS=trueis set in the environment.Rationale:
Previously the /ping endpoint raised exceptions deterministically based on the Unix timestamp, causing 5xx errors and alert noise in production.
This fix allows disabling those deliberate errors in production, while retaining the ability to enable them for testing by setting an environment variable.
No other code or configuration changes are needed for this fix.