fix: disable intentional exception causing 500 errors on /ping endpoint #42
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The
/pingendpoint in the flow-test service was intentionally raising an exception every 3 seconds, causing HTTP 500 errors and triggering alerts.Changes Made
app/main.pyto stop the/pingendpoint from returning 500 errors.Rationale
This fix will stop the
/pingendpoint from sending intermittent errors, which are causing false-positive alerts. The endpoint will now consistently return a successful response, helping monitoring stability.Please redeploy the service after merge and verify that the alert for 500 errors on
/pingstops firing.