Fix flow-test 500 errors by removing intentional exceptions on /ping endpoint #43
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes the ongoing issue that causes the "Flow 500s" alert to fire for the
flow-testservice running in thedemo-prodcluster. The root cause was an intentional exception being raised every 3 seconds when handling the/pingendpoint, causing intermittent 500 errors and alert noise.Changes Made
/pinghandler inapp/main.pythat raisedException("unknown internal error")based on the current time modulo 3./pingalways returns a 200 OK with a simple pong response.Rationale
Removing this forced error simulation prevents the service from sending 500 error responses on a health check endpoint, thus stopping the alert from firing due to these intended failures. This ensures availability monitoring is accurate and not disrupted by artificial errors. If error simulation is still required, it should be constrained to non-production environments outside this deployment.
Following this PR merge and deployment via the standard Plural GitOps flow, the alert should stop firing for this service.
Please review and approve to mitigate the alert noise issue.