-
Notifications
You must be signed in to change notification settings - Fork 9
fix: existing repo setup doesn't ask for ssh key #674
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: existing repo setup doesn't ask for ssh key #674
Conversation
michaeljguarino
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we also do a clone w/ that key to confirm it works? Can clone it into a tempdir.
|
If you just want to do it with an os exec, it'd be something like: GIT_SSH_COMMAND="ssh -i path/to/key" git clone {repo-url} |
I did it in Go |
|
@michaeljguarino PTAL |
| } | ||
| }(dir) | ||
| auth, _ := git.SSHAuth("git", key, "") | ||
| if _, err := git.Clone(auth, url, dir); err != nil { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we send a better error here, eg something like: "ssh key not valid for url {url}, error: {error}"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
Summary
The
Suggestcallback is not for automatically showing a dropdown or list. It only triggers when the user presses the Tab key while typing.Labels
Test Plan
Checklist