Skip to content

Conversation

@zreigz
Copy link
Member

@zreigz zreigz commented Oct 31, 2025

Summary

The Suggest callback is not for automatically showing a dropdown or list. It only triggers when the user presses the Tab key while typing.

Labels

Test Plan

Checklist

  • If required, I have updated the Plural documentation accordingly.
  • I have added tests to cover my changes.
  • I have added a meaningful title and summary to convey the impact of this PR to a user.
  • I have added relevant labels to this PR to help with categorization for release notes.

@zreigz zreigz added the bug-fix This pull request fixes a bug label Oct 31, 2025
@linear
Copy link

linear bot commented Oct 31, 2025

Copy link
Member

@michaeljguarino michaeljguarino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we also do a clone w/ that key to confirm it works? Can clone it into a tempdir.

@michaeljguarino
Copy link
Member

If you just want to do it with an os exec, it'd be something like:

GIT_SSH_COMMAND="ssh -i path/to/key" git clone {repo-url}

@zreigz
Copy link
Member Author

zreigz commented Oct 31, 2025

If you just want to do it with an os exec, it'd be something like:

GIT_SSH_COMMAND="ssh -i path/to/key" git clone {repo-url}

I did it in Go

@zreigz
Copy link
Member Author

zreigz commented Oct 31, 2025

@michaeljguarino PTAL

}
}(dir)
auth, _ := git.SSHAuth("git", key, "")
if _, err := git.Clone(auth, url, dir); err != nil {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we send a better error here, eg something like: "ssh key not valid for url {url}, error: {error}"

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@zreigz zreigz merged commit 5daff86 into main Nov 3, 2025
14 checks passed
@zreigz zreigz deleted the lukasz/prod-3961-existing-repo-setup-doesnt-ask-for-ssh-key branch November 3, 2025 06:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug-fix This pull request fixes a bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants