Skip to content

Conversation

@floreks
Copy link
Member

@floreks floreks commented Nov 4, 2025

Summary

  • Refactored GCP provider
  • Got rid of both direct gcloud calls from within the code and older google.golang.com SDK usage in favor of newer cloud.google.com SDK where applicable
  • Refactored SDK clients usage to a standalone central client that is initialized once and can be reused for the lifecycle of a command call
  • Added user info logs when using GCP provider to show basic information about current user
  • Refactored kube config setup logic to only use SDK instead of gcloud to manually assemble and merge new entry into the local kubeconfig file
  • Extracted user-provided input gathering to InputProvider interface so that survey can be easily replaced later on
  • Improved initial credentials check and error message when ADC is not properly configured
Zrzut ekranu 2025-11-04 115034

Labels

Test Plan

Locally w/ plural up

Checklist

  • If required, I have updated the Plural documentation accordingly.
  • I have added tests to cover my changes.
  • I have added a meaningful title and summary to convey the impact of this PR to a user.
  • I have added relevant labels to this PR to help with categorization for release notes.

@linear
Copy link

linear bot commented Nov 4, 2025

@floreks floreks marked this pull request as draft November 4, 2025 12:53
@floreks floreks self-assigned this Nov 4, 2025
@floreks floreks added the bug-fix This pull request fixes a bug label Nov 4, 2025
@floreks floreks marked this pull request as ready for review November 4, 2025 16:16
@michaeljguarino michaeljguarino merged commit 32415b2 into main Nov 6, 2025
15 of 17 checks passed
@michaeljguarino michaeljguarino deleted the sebastian/prod-3962-gcp-failed-auth-error-messages-stink branch November 6, 2025 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug-fix This pull request fixes a bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants