Skip to content

feat(backend): run the container as non-root #874

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

feat(backend): run the container as non-root #874

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
a8f9762
Add plural user + don’t run the container as root
davidspek Jan 26, 2023
3f1457d
fix: add plural group
davidspek Jan 26, 2023
14c58d5
fix: groupadd-> addgroup
davidspek Jan 26, 2023
bb16ded
fix: rename group in adduser command
davidspek Jan 26, 2023
1ec58ac
Change port to 8080 in config.exs
davidspek Feb 10, 2023
68fe919
Change port to 8080 in rtc.exs
davidspek Feb 10, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,11 +110,18 @@ ENV REPLACE_OS_VARS=true \

WORKDIR /opt/app

# Create plural user and home directory, set owner to plural
RUN addgroup -g 10001 plural && \
adduser -s /bin/sh -u 10001 -G plural -h "/opt/app" -S -D plural && \
chown -R 10001:10001 "/opt/app"

COPY --from=tools /usr/local/bin/plural /usr/local/bin/plural
COPY --from=tools /usr/local/bin/helm /usr/local/bin/helm
COPY --from=tools /usr/local/bin/goon /usr/local/bin/goon
COPY --from=tools /usr/local/bin/terrascan /usr/local/bin/terrascan
COPY --from=tools /usr/local/bin/trivy /usr/local/bin/trivy
COPY --from=builder /opt/built .
COPY --from=builder --chown=10001:10001 /opt/built .

USER plural

CMD trap 'exit' INT; /opt/app/bin/${APP_NAME} foreground
4 changes: 2 additions & 2 deletions rel/config/config.exs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,11 +4,11 @@ import System, only: [get_env: 1]
host = get_env("HOST")

config :api, ApiWeb.Endpoint,
url: [host: host, port: 80],
url: [host: host, port: 8080],
check_origin: ["//#{host}", "//plural-api"]

config :rtc, RtcWeb.Endpoint,
url: [host: host, port: 80],
url: [host: host, port: 8080],
check_origin: ["//#{host}", "//plural-rtc"]

config :core, hostname: host
Expand Down
2 changes: 1 addition & 1 deletion rel/config/rtc.exs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ import Config
import System, only: [get_env: 1]

config :rtc, RtcWeb.Endpoint,
url: [host: get_env("HOST"), port: 80],
url: [host: get_env("HOST"), port: 8080],
check_origin: ["//#{get_env("HOST")}", "//plural-rtc"],
secret_key_base: get_env("SECRET_KEY_BASE"),
server: true
Expand Down