feat: Add service wait resource #104
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maciaszczykm
force-pushed
the
marcin/prod-4111-add-service_wait-resource
branch
from
d9b7023 to
ebd2a2a
Compare
maciaszczykm
force-pushed
the
marcin/prod-4111-add-service_wait-resource
branch
from
ebd2a2a to
5140893
Compare
maciaszczykm
force-pushed
the
marcin/prod-4111-add-service_wait-resource
branch
from
51de0a0 to
f2adc02
Compare
michaeljguarino
approved these changes
Oct 29, 2025
Member
michaeljguarino
left a comment
michaeljguarino
left a comment
There was a problem hiding this comment.
why is there uuid validation code, doesn't seem to be used?
Member
Author
|
@michaeljguarino It is leftover from the initial implementation with service ID. I have left it for the future use. |
michaeljguarino
deleted the
marcin/prod-4111-add-service_wait-resource
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added validators for better user experience.
Tested on plrl-dev-aws.
Should we also wait during update?