Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactors vpn connection module to support all options and targets #310

Merged
merged 6 commits into from
Dec 14, 2023
Merged

Refactors vpn connection module to support all options and targets #310

merged 6 commits into from
Dec 14, 2023

Conversation

lorengordon
Copy link
Member

No description provided.

@lorengordon lorengordon requested a review from a team December 9, 2023 21:33
@lorengordon
Copy link
Member Author

Running make test:

❯ make terraform/pytest PYTEST_ARGS="-v --nomock"
pytest /home/x/git/repos/tardigrade-ci/tests/terraform_pytest -v --nomock
================================================================================== test session starts ===================================================================================platform linux -- Python 3.10.13, pytest-7.4.3, pluggy-1.3.0 -- /home/x/.pyenv/versions/3.10.13/bin/python3.10
cachedir: .pytest_cache
rootdir: /home/x/git/repos
collected 2 items

../tardigrade-ci/tests/terraform_pytest/test_terraform_install.py::test_modules[create_vpn_gateway_with_connections] PASSED                                                                              [ 50%]
../tardigrade-ci/tests/terraform_pytest/test_terraform_install.py::test_modules[create_vpn_gateway] PASSED                                                                                               [100%]

======================================================================================== 2 passed in 475.13s (0:07:55) =========================================================================================
[pytest//home/x/git/repos/tardigrade-ci/tests/terraform_pytest]: Tests executed!

@lorengordon lorengordon force-pushed the refactor branch 3 times, most recently from 8744372 to 93521f3 Compare December 11, 2023 18:51
johnricords
johnricords previously approved these changes Dec 11, 2023
View reviewed changes
eemperor
eemperor reviewed Dec 11, 2023
View reviewed changes
variables.tf Show resolved Hide resolved
eemperor
eemperor previously approved these changes Dec 11, 2023
View reviewed changes
lorengordon and others added 5 commits December 14, 2023 16:37
@lorengordon
Refactors vpn connection module to support all options and targets
2466be4
@lorengordon
Updates tests to work with refactored module
58060b6
@lorengordon
Sends vpn tunnel logs to cloudwatch by default
4d7a304
@lorengordon
Bumps version to 3.0.0
5df915c
@dependabot @lorengordon
chore(deps): Bump plus3it/tardigrade-ci from 0.24.6 to 0.24.15
a127427 
Bumps plus3it/tardigrade-ci from 0.24.6 to 0.24.15.

---
updated-dependencies:
- dependency-name: plus3it/tardigrade-ci
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
@lorengordon lorengordon merged commit fd02beb into plus3it:master Dec 14, 2023
4 of 5 checks passed
@lorengordon lorengordon deleted the refactor branch December 14, 2023 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dwc0011 dwc0011 dwc0011 approved these changes

@johnricords johnricords johnricords left review comments

@eemperor eemperor eemperor left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lorengordon @eemperor @dwc0011 @johnricords