For virt machine type, add highmem* virt machine type options to the machine_args shell script variable #167
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
run_qemu.sh
Outdated
| @@ -1677,6 +1677,9 @@ prepare_qcmd() | |||
| if [[ $_arg_cxl == "on" ]]; then | |||
| machine_args+=("cxl=on") | |||
| fi | |||
| if [[ "${host_arch}" == "aarch64" ]]; then | |||
There was a problem hiding this comment.
When using bash's [[ ]] no need to quote the variable, or indeed use ${} - the left side can just be $host_arch
|
@stellarhopper done. Thanks for your review. |
marc-hb
requested changes
Apr 16, 2025
Looks goot to me so. Co-authored-by: Marc Herbert <[email protected]>
marc-hb
reviewed
Apr 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested-by: Itaru Kitayama <[email protected]>