run_qemu.sh: un-hardcode /dev/sda2 in QEMU parameters #174
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes pmem#137. Hardcoding also reported in pmem#140 Leverages old code already used by /efi and --no-direct-kernel. This commit affects only --direct-kernel Signed-off-by: Marc Herbert <[email protected]>
marc-hb
added a commit
to marc-hb/run_qemu
that referenced
this pull request
Apr 21, 2025
Faster and more reliable. Needed for unhardcoding /dev/sda2 pmem#174 without making `run_qemu.sh -r none` much slower. Signed-off-by: Marc Herbert <[email protected]>
|
Needs #177 optimization first, otherwise this makes |
marc-hb
added a commit
that referenced
this pull request
Apr 22, 2025
Faster and more reliable. Needed for unhardcoding /dev/sda2 #174 without making `run_qemu.sh -r none` much slower. Signed-off-by: Marc Herbert <[email protected]>
|
@ikitayama could you test this small change? |
stellarhopper
approved these changes
Apr 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #137. Hardcoding also reported in #140
Leverages old code already used by /efi and --no-direct-kernel.
This commit affects only --direct-kernel