Loopback fixes #176
Merged
Loopback fixes #176
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stellarhopper
approved these changes
Apr 21, 2025
It's safe enough because we grep $_arg_rootfs Also log the losetup -d with set -x, otherwise error messages to detach stuff that has already been detached are too confusing. Signed-off-by: Marc Herbert <[email protected]>
Fixes commit 60dbab3 "run_qemu.sh: de-duplicate new function get_loopdev()" which captured the output of the entire, new get_loopdev() function. Among others, this sheds light on the bug fixed in the next commit (when there is zero loopback device). Also use fail() more, it adds a useful "FATAL: " prefix. Eventually, fail() should probably be redirected to stderr every time? Signed-off-by: Marc Herbert <[email protected]>
1. loopdev="$( )" removes the trailing newline when any 2. wc -l <<<"$loopdev" re-adds a trailing new line 1+2 return the correct count EXCEPT when $loopdev is empty: 0 becomes 1! Stop counting newlines because it's impossible to make the difference between 0 and 1 loopback device with them. Count 'dev/loop' lines instead. Fixes commit 47e3500 ("run_qemu: detect stale loopdev mounts") which always did detect stale mounts but aborted without an error message when there is no loopback mount. Signed-off-by: Marc Herbert <[email protected]>
stellarhopper
approved these changes
Apr 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.