Skip to content

fix(Fbo): WebGLRenderTargetOptions from THREE.WebGLRenderTarget #2484

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 5, 2025

Conversation

abernier
Copy link
Member

@abernier abernier commented Jul 5, 2025

Copy link

vercel bot commented Jul 5, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
drei ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 5, 2025 3:28pm

Copy link

codesandbox-ci bot commented Jul 5, 2025

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@abernier abernier changed the title WebGLRenderTargetOptions from THREE.WebGLRenderTarget fix: WebGLRenderTargetOptions from THREE.WebGLRenderTarget Jul 5, 2025
@abernier abernier changed the title fix: WebGLRenderTargetOptions from THREE.WebGLRenderTarget fix(Fbo): WebGLRenderTargetOptions from THREE.WebGLRenderTarget Jul 5, 2025
@abernier abernier mentioned this pull request Jul 5, 2025
3 tasks
@Methuselah96
Copy link
Contributor

Thanks!

@abernier abernier merged commit 1c89859 into master Jul 5, 2025
5 checks passed
@abernier abernier deleted the fbo-fix-types3 branch July 5, 2025 15:51
@abernier
Copy link
Member Author

abernier commented Jul 5, 2025

@Methuselah96 released https://github.com/pmndrs/drei/releases/tag/v10.4.3

@Methuselah96
Copy link
Contributor

Methuselah96 commented Jul 5, 2025

@abernier Thanks for the quick fix! Unfortunately there's still a reference to THREE.WebGLRenderTargetOptions in the built type declarations on line 22 of Fbo.d.ts:

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants