Update three.js dependency #181
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Moved loaders to classes, three.js does not use default export as it was used before. * Type definition for exports. * three.js version bumped to at least first that introduces breaking change to euler to vector conversion. * New pattern for vector from euler conversion applied.
|
sorry it took so long, i kind of keep missing important github notification which get swept out by unimportant stuff. :( would it be possible to resolve still? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses #179.
Due to major changes between three.js versions, a lot of code regarding classes and exports was changed. I have only touched the parser's toVector3 conversion.
I have tested conversion to JSX and transformation with some GLTFs of my own, but please make sure, there might be stuff that I missed.