Skip to content

Chore three-stdlib #140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Chore three-stdlib #140

wants to merge 2 commits into from

Conversation

ospira
Copy link

@ospira ospira commented Jul 15, 2025

Dep tree had a mismatch, see: mrdoob/three.js#30934 and pmndrs/three-stdlib#419. Having the older stdlib made freshly cloned/installed repo fail when running commands such as pnpm run app boids

I opted to just bump the stdlib to the version that had the fix, rather than the latest version available as that felt safer 😛

Note also that some lines re react types got updated as well, which makes the diff less clean than I would have liked but these appear to be in keeping with the dep specification.

Running with this diff allowed me to run the examples on a new machine without error, as I was able to previously.

Thanks!

@ospira
Copy link
Author

ospira commented Jul 16, 2025

See also: pmndrs/drei#2455

Note running pnpm update solves the problem as well, but I was aiming for as small a diff as possible, even though this is not a direct dependency. Just wanted to clarify drei as the source in the dep tree for this issue in case that was unclear.

@krispya
Copy link
Member

krispya commented Jul 16, 2025

Hey thanks! But shouldn't we bump the versions in package.json also and not just the lock file?

@ospira
Copy link
Author

ospira commented Jul 16, 2025

Hey thanks! But shouldn't we bump the versions in package.json also and not just the lock file?

So yes, it might seem wrong at first but I believe this is correct (or at least, just as viable and more specific) because it's not a direct dep and since drei doesn't enforce the higher stdlib, updating the package.json (you could just run pnpm update to fix as well) felt too heavy/misleading. It's not that drei itself needs to be updated it's that one of their deps needs to be set to a more recent version for the version of three we are running here (they allow for a far older version).

Ultimately though it's up to you! 😄 I totally get if you prefer a broader update that goes beyond just touching the lockfile as I get that can seem off. Given this is also my first PR here I opted for smallest diff / greatest specificity here. If you prefer I update drei recursively that works for me. Thanks!

@krispya
Copy link
Member

krispya commented Jul 16, 2025

Oh I see what you mean now. Sure, let's try it this way for now and we can take it from there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants