fix(createPortal): ensure container is wrapped in Scene#3247
Closed
CodyJasonBennett wants to merge 269 commits intomasterfrom
Closed
fix(createPortal): ensure container is wrapped in Scene#3247CodyJasonBennett wants to merge 269 commits intomasterfrom
CodyJasonBennett wants to merge 269 commits intomasterfrom
Conversation
This reverts commit f23ecaf.
…ixedStages also has substepDeltas returning an array of deltas for each substep
…alues and now that we have deltas there are useland ways to hanlde this
feat: implement update lifecycle with useUpdate
Releases: @react-three/[email protected] @react-three/[email protected] [skip ci]
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit d92501c:
|
CodyJasonBennett
commented
May 1, 2024
Member
|
I think a better solution is to have |
CodyJasonBennett
changed the title
DennisSmolek
added a commit
to DennisSmolek/react-three-fiber
that referenced
this pull request
Dec 22, 2025
closes: pmndrs#2735 updates pmndrs#3247
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2725.