Skip to content

Conversation

krispya
Copy link
Member

@krispya krispya commented Jul 9, 2025

Here begins my introduction to triaging the React reconciler. In this PR you will see...

@krispya krispya requested a review from CodyJasonBennett July 9, 2025 15:01
Copy link

codesandbox-ci bot commented Jul 9, 2025

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 0afec9b:

Sandbox Source
example Configuration

"buffer": "^6.0.3",
"its-fine": "^2.0.0",
"react-reconciler": "^0.31.0",
"react-reconciler": "^0.32.0",
Copy link
Member

@CodyJasonBennett CodyJasonBennett Jul 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a breaking change, as react-reconciler 0.32 corresponds to React 19.1.

Been thinking on this, since we could risk not supporting 19.x. We can choose to inline if we're sure it is backwards compatible.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a good catch. I'll verify this.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I confirmed flushSyncFromReconciler is in v0.31 as well. I think it is safe to use it without inlining. We now have a test for flushSync so going forward we can know if this breaks when updating the reconciler. I'll downgrade the minimum version though as you pointed out.

@krispya krispya merged commit 7264b7c into master Jul 18, 2025
2 checks passed
@krispya krispya deleted the chore/export-flush-sync branch July 18, 2025 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants