[spike] make root optional in container #78
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
itsdouges
commented
Jun 6, 2024
| return parent | ||
| } | ||
|
|
||
| export function useParentOptional(): ParentContext { |
Author
There was a problem hiding this comment.
We could rename the other hook to useParentOrThrow and this one to useParent. Happy with whatever.
Contributor
|
@itsdouges thanks for the PR
Would love to discuss possible solutions and consolidate ideas to solve these things :) |
bbohlender
force-pushed
the
main
branch
2 times, most recently
from
97df98e to
7939942
Compare
Contributor
|
going to close this, as its already part of the uikit 1.0 roadmap |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey @bbohlender here's a quick spike to test the waters. We'd conditionally render
<Root>if it's missing in what we'd consider "top level components".Should that be all components? If you have a list that should be changed and are happy with the approach I can do it all, add tests, and get it into a mergeable state.