Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(proxySet): fix .symmetricDifference,.isDisjointFrom; add .difference #1040

Merged
merged 3 commits into from
Jan 26, 2025

Conversation

magicdawn
Copy link
Contributor

@magicdawn magicdawn commented Jan 22, 2025

Related Bug Reports or Discussions

N/A

Summary

  • add missing .difference method
  • fix incorrect implemented .symmetricDifference & .isDisjointFrom
  • copy mdn examples as basic Unit Test
  • re-order these methods according to the proposal page

the proposal
https://github.com/tc39/proposal-set-methods?tab=readme-ov-file#proposal

Check List

  • pnpm run fix:format for formatting code and docs

Copy link

vercel bot commented Jan 22, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
valtio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 26, 2025 3:58am

Copy link

codesandbox-ci bot commented Jan 22, 2025

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Copy link

pkg-pr-new bot commented Jan 22, 2025

Open in Stackblitz

More templates

npm i https://pkg.pr.new/valtio@1040

commit: 48c7aae

Copy link
Collaborator

@overthemike overthemike left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! It's much appreciated. I didn't spend nearly enough time diving deep into these when first implementing. Good looking out and well done.

Verified (quickly) these changes are indeed the correct implementation for these methods.

@dai-shi dai-shi merged commit 2655270 into pmndrs:main Jan 26, 2025
28 checks passed
@magicdawn magicdawn deleted the fix-set-methods branch February 4, 2025 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants