Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(utils): updated deepClone to handle proxyMap and proxySet #1074

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

overthemike
Copy link
Collaborator

Related Bug Reports or Discussions

1072
Fixes #
1072

Summary

Added isProxyMap and isProxySet methods and fixed deepClone to handle proxySets and proxyMaps. Also added tests for deepClone.

Check List

  • [x ] pnpm run fix for formatting and linting code and docs

Copy link

vercel bot commented Mar 16, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
valtio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 16, 2025 10:14pm

@overthemike overthemike requested a review from dai-shi March 16, 2025 22:14
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Copy link

pkg-pr-new bot commented Mar 16, 2025

Open in Stackblitz

More templates

npm i https://pkg.pr.new/valtio@1074

commit: 60aac5e

Copy link

Size Change: +138 B (+1.01%)

Total Size: 13.8 kB

Filename Size Change
./dist/esm/vanilla/utils.mjs 3.24 kB +68 B (+2.14%)
./dist/vanilla/utils.js 3.27 kB +70 B (+2.19%)
ℹ️ View Unchanged
Filename Size
./dist/esm/index.mjs 63 B
./dist/esm/react.mjs 695 B
./dist/esm/react/utils.mjs 257 B
./dist/esm/utils.mjs 68 B
./dist/esm/vanilla.mjs 2.35 kB
./dist/index.js 243 B
./dist/react.js 686 B
./dist/react/utils.js 278 B
./dist/utils.js 248 B
./dist/vanilla.js 2.39 kB

compressed-size-action

Copy link
Member

@dai-shi dai-shi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dai-shi dai-shi changed the title updated deepClone to handle proxyMap and proxySet fix(utils): updated deepClone to handle proxyMap and proxySet Mar 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants