Skip to content

update vitest #879

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dai-shi merged 11 commits into from
Apr 6, 2024
Merged

update vitest #879

dai-shi merged 11 commits into from
Apr 6, 2024

Conversation

@dai-shi
Copy link
Member

@dai-shi dai-shi commented Apr 5, 2024

@vercel
Copy link

vercel bot commented Apr 5, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
valtio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 5, 2024 3:32pm

@codesandbox-ci
Copy link

codesandbox-ci bot commented Apr 5, 2024 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@github-actions
Copy link

github-actions bot commented Apr 5, 2024 •
edited
Loading

Size Change: 0 B

Total Size: 60.7 kB

ℹ️ View Unchanged
Filename Size
dist/esm/index.js 62 B
dist/esm/macro.js 698 B
dist/esm/macro/vite.js 864 B
dist/esm/react.js 732 B
dist/esm/react/utils.js 258 B
dist/esm/utils.js 68 B
dist/esm/vanilla.js 2.44 kB
dist/esm/vanilla/utils.js 3.17 kB
dist/index.js 243 B
dist/macro.js 919 B
dist/macro/vite.js 1.08 kB
dist/react.js 668 B
dist/react/utils.js 277 B
dist/system/index.development.js 253 B
dist/system/index.production.js 183 B
dist/system/macro.development.js 780 B
dist/system/macro.production.js 556 B
dist/system/macro/vite.development.js 951 B
dist/system/macro/vite.production.js 660 B
dist/system/react.development.js 872 B
dist/system/react.production.js 473 B
dist/system/react/utils.development.js 357 B
dist/system/react/utils.production.js 237 B
dist/system/utils.development.js 259 B
dist/system/utils.production.js 187 B
dist/system/vanilla.development.js 2.58 kB
dist/system/vanilla.production.js 1.52 kB
dist/system/vanilla/utils.development.js 3.38 kB
dist/system/vanilla/utils.production.js 2.22 kB
dist/umd/index.development.js 382 B
dist/umd/index.production.js 330 B
dist/umd/macro.development.js 1.03 kB
dist/umd/macro.production.js 721 B
dist/umd/macro/vite.development.js 1.23 kB
dist/umd/macro/vite.production.js 879 B
dist/umd/react.development.js 814 B
dist/umd/react.production.js 526 B
dist/umd/react/utils.development.js 433 B
dist/umd/react/utils.production.js 314 B
dist/umd/utils.development.js 398 B
dist/umd/utils.production.js 344 B
dist/umd/vanilla.development.js 2.76 kB
dist/umd/vanilla.production.js 1.64 kB
dist/umd/vanilla/utils.development.js 7.17 kB
dist/umd/vanilla/utils.production.js 4.93 kB
dist/utils.js 247 B
dist/vanilla.js 2.63 kB
dist/vanilla/utils.js 6.99 kB

compressed-size-action

@dai-shi dai-shi marked this pull request as ready for review April 5, 2024 15:37
dai-shi
dai-shi commented Apr 5, 2024
View reviewed changes
.github/workflows/test-multiple-builds.yml
run: |
sed -i~ "s/it[.a-zA-Z]*('\[PRD-ONLY\]/it('/" tests/*.ts tests/*.tsx
sed -i~ "s/it[.a-zA-Z]*('\[DEV-ONLY\]/it.skip('/" tests/*.ts tests/*.tsx
sed -i~ "s/describe(/describe.skip(/" tests/memoryleaks.test.ts # FIXME why it doesn't work in production mode?
Copy link
Member Author

@dai-shi dai-shi Apr 5, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be fixed. Help wanted.

Copy link
Member Author

@dai-shi dai-shi Apr 7, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in #880.

@dai-shi dai-shi merged commit dcf48e4 into main Apr 6, 2024
@dai-shi dai-shi deleted the chore/update-vitest branch April 6, 2024 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dai-shi