fix: vr sessions with unbounded

pmndrs · Aug 1, 2024 · dee27cc · dee27cc
1 parent b92123a
commit dee27cc
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/packages/xr/src/init.ts b/packages/xr/src/init.ts
@@ -51,6 +51,7 @@ export type XRSessionInitOptions = {
 }
 
 export function buildXRSessionInit(
+  mode: XRSessionMode,
   domOverlayRoot: Element,
   {
     anchors = true,
@@ -84,7 +85,9 @@ export function buildXRSessionInit(
   addXRSessionFeature(depthSensing, 'depth-sensing', requiredFeatures, optionalFeatures)
   addXRSessionFeature(domOverlay, 'dom-overlay', requiredFeatures, optionalFeatures)
   addXRSessionFeature(hitTest, 'hit-test', requiredFeatures, optionalFeatures)
-  addXRSessionFeature(unbounded, 'unbounded', requiredFeatures, optionalFeatures)
+  if (mode != 'immersive-vr') {
+    addXRSessionFeature(unbounded, 'unbounded', requiredFeatures, optionalFeatures)
+  }
 
   return {
     requiredFeatures,

diff --git a/packages/xr/src/store.ts b/packages/xr/src/store.ts
@@ -556,7 +556,7 @@ async function enterXR(
   if (xrManager == null) {
     return Promise.reject(new Error(`not connected to three.js. Missing are <XR> component?`))
   }
-  const session = await navigator.xr.requestSession(mode, buildXRSessionInit(domOverlayRoot, options))
+  const session = await navigator.xr.requestSession(mode, buildXRSessionInit(mode, domOverlayRoot, options))
   setFrameRate(session, options?.frameRate ?? 'high')
   setupXRManager(xrManager, session, options)
   return session