docs(README): remove 'omit' in 'Overwriting state' section #3160
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
sukvvon
force-pushed
the
docs/README-replace-lodash-with-es-toolkit
branch
from
6cf85c2 to
ef95383
Compare
README.md
Outdated
| @@ -125,7 +125,7 @@ const treats = useBearStore( | |||
| The `set` function has a second argument, `false` by default. Instead of merging, it will replace the state model. Be careful not to wipe out parts you rely on, like actions. | |||
|
|
|||
| ```jsx | |||
| import { omit } from 'es-toolkit/compat' | |||
| import omit from 'es-toolkit/compat/omit' | |||
There was a problem hiding this comment.
How does it look like?
There was a problem hiding this comment.
No. I mean to avoid using the external library at all.
There was a problem hiding this comment.
I'm down with you @dai-shi, we should remove the external lib in this case and replace it with Object.fromEntries(...) + Object.entries() + .filter()
README.md
Outdated
| import omit from 'lodash-es/omit' | ||
| function omit(obj, keys) { | ||
| const result = { ...obj } | ||
|
|
||
| for (let i = 0; i < keys.length; i++) { | ||
| const key = keys[i] | ||
| delete result[key] | ||
| } | ||
|
|
||
| return result | ||
| } |
There was a problem hiding this comment.
How does it look like?
There was a problem hiding this comment.
It looks like not FP, perhaps it should be like this:
const omit = keysToOmit => obj =>
Object.fromEntries(
Object.entries(obj).filter(([key]) => !keysToOmit.includes(key))
);There was a problem hiding this comment.
function omit(obj, keys) {
return Object.fromEntries(
Object.entries(obj).filter(([key]) => !keys.includes(key))
)
}I understand what you’re saying, but I’ve already taken browser compatibility into consideration for now.
There was a problem hiding this comment.
Please don't create a util function. Just do it in the store action in a simple way.
sukvvon
force-pushed
the
docs/README-replace-lodash-with-es-toolkit
branch
from
05d7c65 to
8fb8fbe
Compare
sukvvon
changed the title
sukvvon
changed the title
README.md
Outdated
| import omit from 'lodash-es/omit' | ||
|
|
||
| const useFishStore = create((set) => ({ | ||
| salmon: 1, | ||
| tuna: 2, | ||
| deleteEverything: () => set({}, true), // clears the entire store, actions included | ||
| deleteTuna: () => set((state) => omit(state, ['tuna']), true), | ||
| deleteTuna: () => | ||
| set((state) => { | ||
| const { tuna, ...rest } = state | ||
| return rest | ||
| }, true), | ||
| })) |
There was a problem hiding this comment.
I reflected your opinion.
There was a problem hiding this comment.
Cool. I'm not sure if we prefer this, but we could also do this.
set(({ tuna, ...rest }) => rest, true);@dbritto-dev thoughts?
There was a problem hiding this comment.
Sounds good. I reflected your opinion.
There was a problem hiding this comment.
@dai-shi I'm down with you
Related Bug Reports or Discussions
Fixes #
Summary
Check List
pnpm run fixfor formatting and linting code and docs