Skip to content

chore(vitest.config): enable 'typecheck' and 'coverage' #3163

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

sukvvon
Copy link
Contributor

@sukvvon sukvvon commented Jun 30, 2025

Related Bug Reports or Discussions

Fixes #

Summary

enabling this options, when we run pnpm run test:spec, we can see typecheck and coverage

Check List

  • pnpm run fix for formatting and linting code and docs

Copy link

vercel bot commented Jun 30, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
zustand-demo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 30, 2025 0:39am

Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Copy link

pkg-pr-new bot commented Jun 30, 2025

demostarter

npm i https://pkg.pr.new/zustand@3163

commit: 3759cdd

@dai-shi
Copy link
Member

dai-shi commented Jul 1, 2025

I would like coverage to be opt-in, and I guess typecheck is covered by test:types.

@sukvvon
Copy link
Contributor Author

sukvvon commented Jul 1, 2025

I would like coverage to be opt-in, and I guess typecheck is covered by test:types.

@dai-shi

Since test:types already covers type checking, I think we can exclude typecheck.
As for coverage, I think with this single setting, we can get both test results and coverage reports.
It could also eliminate the need to run something like pnpm run test:spec --coverage.

@dai-shi
Copy link
Member

dai-shi commented Jul 1, 2025

we prefer pnpm run test:spec --coverage for now. We may change our mind in the future.

Thanks for the suggestion anyway!

@dai-shi dai-shi closed this Jul 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants