Skip to content

note about CPU utilization of ABT_cond_timedwait() #406

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 28, 2025
Merged

note about CPU utilization of ABT_cond_timedwait() #406

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4a4b685
note about CPU utilization of ABT_cond_timedwait()
Sep 10, 2025
25b2381
making the whitespaces action happy about this PR
mdorier Nov 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions src/cond.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -222,6 +222,14 @@ int ABT_cond_wait(ABT_cond cond, ABT_mutex mutex)
* Unlike other implementations of condition variables, a spurious wakeup never
* occurs.
*
* @note
* This function exhibits significantly higher CPU utilization than
* ABT_cond_wait() when blocking, even with the BASIC_WAIT scheduler. This
* is because Argobots lacks a user-space timeout mechanism, requiring
* continuous rescheduling of the caller to poll for `abstime`. The
* `--enable-sched-sleep` option can mitigate this, but it introduces a
* latency penalty for some workloads.
*
* @contexts
* \DOC_CONTEXT_ANY \DOC_CONTEXT_CTXSWITCH
*
Expand Down
2 changes: 1 addition & 1 deletion src/include/abti_error.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@

#define ABTI_STATIC_ASSERT(cond) \
do { \
((void)sizeof(char[2 * !!(cond)-1])); \
((void)sizeof(char[2 * !!(cond) - 1])); \
} while (0)

#ifdef ABT_CONFIG_PRINT_ABT_ERRNO
Expand Down
2 changes: 1 addition & 1 deletion test/basic/info_query.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ void info_query_all(ABT_bool init)
while (p_query) {
if (!(p_query->need_init && !init)) {
const int idx = p_query->buffer_idx++;
int32_t *ptr = (int32_t *)(&p_query->buffers[1 + (idx)*3]);
int32_t *ptr = (int32_t *)(&p_query->buffers[1 + (idx) * 3]);
ptr[-1] = 0x77777777;
ptr[0] = 0x77777777;
ptr[1] = 0x77777777;
Expand Down
2 changes: 1 addition & 1 deletion test/benchmark/thread_ops.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
#include "abt.h"
#include "abttest.h"

//#define TEST_MIGRATE_TO
// #define TEST_MIGRATE_TO
#define USE_JOIN_MANY
#ifdef USE_JOIN_MANY
#define ABT_THREAD_JOIN_MANY(n, tl) ABT_thread_join_many(n, tl)
Expand Down
2 changes: 1 addition & 1 deletion test/benchmark/thread_ops_all.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
#include "abt.h"
#include "abttest.h"

//#define TEST_MIGRATE_TO
// #define TEST_MIGRATE_TO
#define USE_JOIN_MANY
#ifdef USE_JOIN_MANY
#define ABT_THREAD_JOIN_MANY(n, tl) ABT_thread_join_many(n, tl)
Expand Down