test/mpi: Add non-collective sessions init test#7429
Open
raffenet wants to merge 3 commits intopmodels:mainfrom
Open
test/mpi: Add non-collective sessions init test#7429raffenet wants to merge 3 commits intopmodels:mainfrom
raffenet wants to merge 3 commits intopmodels:mainfrom
Conversation
Contributor
Author
|
test:mpich/ch4/most |
raffenet
force-pushed
the
session-non-coll
branch
from
8bd3d15 to
05bfcfb
Compare
Contributor
Author
|
test:mpich/ch4/most |
hzhou
reviewed
May 22, 2025
test/mpi/session/session_non_coll.c
Outdated
|
|
||
| MPI_Session_init(MPI_INFO_NULL, MPI_ERRORS_ABORT, &session); | ||
| MPI_Group_from_session_pset(session, "mpi://world", &group); | ||
| MPI_Group_rank(group, &rank); |
Contributor
There was a problem hiding this comment.
Also check size and the tests require size > 1
Contributor
Author
There was a problem hiding this comment.
new version does this
raffenet
force-pushed
the
session-non-coll
branch
from
05bfcfb to
694d395
Compare
raffenet
commented
May 22, 2025
hzhou
requested changes
Jun 5, 2025
raffenet
force-pushed
the
session-non-coll
branch
from
694d395 to
3d34b45
Compare
Contributor
Author
|
test:mpich/ch4/most |
raffenet
commented
Jun 20, 2025
raffenet
force-pushed
the
session-non-coll
branch
from
3d34b45 to
cb178ff
Compare
Contributor
Author
|
test:mpich/ch4/most |
raffenet
force-pushed
the
session-non-coll
branch
from
cb178ff to
2f0c8f4
Compare
Contributor
Author
|
test:mpich/ch4/most |
Contributor
Author
|
The test fails with ch4:ofi when the PSM3 provider is selected. Will address these issues in a follow-up patch. |
Contributor
Author
This is actually the same issue. When |
raffenet
force-pushed
the
session-non-coll
branch
from
957b73a to
e8ca9fb
Compare
Contributor
Author
|
test:mpich/ch4/most |
raffenet
force-pushed
the
session-non-coll
branch
from
e8ca9fb to
8252c6b
Compare
Contributor
Author
|
test:mpich/ch4/most |
raffenet
force-pushed
the
session-non-coll
branch
from
8252c6b to
b227125
Compare
Contributor
Author
|
test:mpich/ch4/most |
raffenet
force-pushed
the
session-non-coll
branch
from
b227125 to
4d547f2
Compare
Contributor
Author
|
test:mpich/ch4/most |
raffenet
force-pushed
the
session-non-coll
branch
from
4d547f2 to
2d0cbf3
Compare
Add a test to verify the local only behavior of MPI_Session_init. To do so, we launch an extra process via mpiexec that will never call MPI_Session_init.
If there is no MPI_COMM_WORLD, we should skip calling a global PMI barrier during finalization. It is not guaranteed that world processes have initialized MPI (thus PMI), so a barrier could hang.
raffenet
force-pushed
the
session-non-coll
branch
from
2d0cbf3 to
4b8a027
Compare
Contributor
Author
|
test:mpich/ch4/most |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Add a test to verify the non-collective behavior of
MPI_Session_init. First, run a collective init/finalize sequence over
all launched processes. Second, try to re-initialize and finalize a new
session from just a single process and ensure it does not hang.
Author Checklist
Particularly focus on why, not what. Reference background, issues, test failures, xfail entries, etc.
Commits are self-contained and do not do two things at once.
Commit message is of the form:
module: short descriptionCommit message explains what's in the commit.
Whitespace checker. Warnings test. Additional tests via comments.
For non-Argonne authors, check contribution agreement.
If necessary, request an explicit comment from your companies PR approval manager.