ch4/ucx: Use UCX datatypes in active message path #7538
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
test:mpich/ch4/ucx |
Contributor
Author
|
test:mpich/ch4/gpu/ucx |
Contributor
Author
|
Looks to be a bug in the setting of the received size of noncontig am recv, so dropped that part for now. |
raffenet
force-pushed
the
ucx-am-dt
branch
3 times, most recently
from
092506d to
8899fa9
Compare
Contributor
Author
|
test:mpich/ch4/ucx |
Contributor
Author
|
whitespace checker has me in a blender 😦 |
Contributor
Author
|
test:mpich/ch4/ucx |
Contributor
Author
|
test:mpich/ch4/gpu/ucx |
Since we already have the request, we can always put it in the user_data parameter and avoid some complexity.
UCX has support for noncontig datatypes in the nbx active message send interface. Use it like we do in the tagged path.
Contributor
Author
|
test:mpich/ch4/gpu/ucx |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Splitting non-GPU commits from #6795 for testing.
Author Checklist
Particularly focus on why, not what. Reference background, issues, test failures, xfail entries, etc.
Commits are self-contained and do not do two things at once.
Commit message is of the form:
module: short descriptionCommit message explains what's in the commit.
Whitespace checker. Warnings test. Additional tests via comments.
For non-Argonne authors, check contribution agreement.
If necessary, request an explicit comment from your companies PR approval manager.