Skip to content
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
38 commits
Select commit Hold shift + click to select a range
d3114f7
mpit: fix an unused function warning
hzhou Sep 4, 2025
8beb293
ADI: remove MPID collectives
hzhou Aug 22, 2025
165b2a8
maint: move json_gen.sh to top of maint folder
hzhou Aug 25, 2025
50591f0
ch4/coll: remove device-layer json selections
hzhou Aug 22, 2025
c71e8d0
ch4: disable the code that call netmod/shm collectives
hzhou Aug 23, 2025
f97f238
ch4/api: remove netmod/shm collective api
hzhou Aug 22, 2025
07b1f46
ch4: remove device-layer json csel
hzhou Aug 24, 2025
064219b
ch4/shm: inclusion order for shm_am.h
hzhou Aug 23, 2025
de5b21b
all: use fallback routines for internal collectives
hzhou Aug 23, 2025
81a2a0e
ch3: use MPIR_Barrier_fallback internally
hzhou Sep 4, 2025
b881a0e
temp auto
hzhou Sep 4, 2025
38a359c
coll: remove fallback in collective algorithm
hzhou Aug 23, 2025
c158a6b
coll/prep: just use fallback in tsp auto functions
hzhou Aug 25, 2025
ba1f8a1
coll/prep: remove the optional json search for parameters
hzhou Aug 25, 2025
0015b9d
coll/prep: call MPIR collectives in compositional algorithms
hzhou Aug 23, 2025
aff0344
coll/csel: rename coll_info to coll_sig
hzhou Aug 19, 2025
94b5167
coll/csel: pass coll_sig by pointer
hzhou Aug 21, 2025
a84f749
coll/csel: merge csel_container.h into mpir_csel.h
hzhou Aug 21, 2025
4240842
coll: add coll_composition.json and coll_selection.json
hzhou Aug 21, 2025
1148f74
coll: add MPIR_Coll_auto and MPIR_Composition_auto
hzhou Aug 21, 2025
6eeb90d
coll: add MPIR_Coll_nb
hzhou Aug 24, 2025
f299f3b
coll: remove all allcomm_nb algorithms
hzhou Sep 4, 2025
9f7a03a
coll: add abstract coll algo interface and auto functions
hzhou Aug 21, 2025
d841c5f
coll/gen_coll: dump algo functions
hzhou Aug 22, 2025
04132aa
coll/python: generate impl functions
hzhou Aug 22, 2025
1ff54b8
coll/gen_coll: temporarily generate MPIR collectives
hzhou Aug 23, 2025
aef7585
misc: only include json.h where needed
hzhou Aug 24, 2025
c2ed36d
coll: reorganize csel headers
hzhou Aug 24, 2025
1ce92c8
coll/csel: remove MPIR_Csel_prune
hzhou Sep 2, 2025
476a700
coll/gen_coll: generate algorithm container ids
hzhou Aug 24, 2025
30147f4
misc: spelling check
hzhou Aug 25, 2025
96b7df9
coll: remove the alias feature in coll_algorithms.txt
hzhou Aug 24, 2025
fcb9ede
coll: remove MPIR_Csel_root
hzhou Aug 25, 2025
5982317
coll/csel: new coll_algorithms.txt
hzhou Sep 4, 2025
d37a869
coll/csel: new coll_selection.json
hzhou Sep 4, 2025
da6ea18
coll/gen: update gen_coll.py
hzhou Sep 5, 2025
1dec880
ADI/csel: add hooks for initializing coll_sig
hzhou Aug 28, 2025
e3acd5a
coll/csel: update csel
hzhou Aug 24, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion autogen.sh
Original file line number Diff line number Diff line change
Expand Up @@ -531,7 +531,7 @@ fn_gen_binding_c() {

fn_json_gen() {
echo_n "generating json char arrays... "
./maint/tuning/coll/json_gen.sh
./maint/json_gen.sh
echo "done"
}

Expand Down
1,380 changes: 816 additions & 564 deletions maint/gen_coll.py

Large diffs are not rendered by default.

5 changes: 2 additions & 3 deletions maint/tuning/coll/json_gen.sh → maint/json_gen.sh
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,5 @@ cat > $cfile<<EOF
EOF

# create specific json buffers
create_json_buf maint/tuning/coll/mpir/generic.json MPII_coll_generic_json
create_json_buf maint/tuning/coll/ch4/generic.json MPIDI_coll_generic_json
create_json_buf maint/tuning/coll/ch4/posix_generic.json MPIDI_POSIX_coll_generic_json
create_json_buf src/mpi/coll/coll_composition.json MPII_coll_composition_json
create_json_buf src/mpi/coll/coll_selection.json MPII_coll_selection_json
33 changes: 0 additions & 33 deletions maint/local_python/binding_c.py
Original file line number Diff line number Diff line change
Expand Up @@ -1782,17 +1782,9 @@ def push_impl_decl(func, impl_name=None):

if func['_impl_param_list']:
params = ', '.join(func['_impl_param_list'])
if func['dir'] == 'coll':
# block collective use an extra coll_attr
if not RE.match(r'MPI_(I.*|Neighbor.*|.*_init)$', func['name']):
params = params + ", int coll_attr"
else:
params="void"

if func['dir'] == 'coll':
# collective also dump MPIR_Xxx(...)
mpir_name = re.sub(r'^MPIX?_', 'MPIR_', func['name'])
G.impl_declares.append("int %s(%s);" % (mpir_name, params))
# dump MPIR_Xxx_impl(...)
if func['dir'] == 'io':
G.io_impl_declares.append("int %s(%s);" % (impl_name, params))
Expand Down Expand Up @@ -1821,29 +1813,6 @@ def dump_CHECKENUM(var, errname, t, type="ENUM"):
G.out.append("goto fn_fail;")
dump_if_close()

def dump_body_coll(func):
# collectives call MPIR_Xxx
mpir_name = re.sub(r'^MPIX?_', 'MPIR_', func['name'])

args = ", ".join(func['_impl_arg_list'])

if RE.match(r'MPI_(I.*|.*_init)$', func['name'], re.IGNORECASE):
# non-blocking collectives
G.out.append("MPIR_Request *request_ptr = NULL;")
dump_line_with_break("mpi_errno = %s(%s);" % (mpir_name, args))
dump_error_check("")
G.out.append("if (!request_ptr) {")
G.out.append(" request_ptr = MPIR_Request_create_complete(MPIR_REQUEST_KIND__COLL);")
G.out.append("}")
G.out.append("*request = request_ptr->handle;")
elif RE.match(r'mpi_neighbor_', func['name'], re.IGNORECASE):
dump_line_with_break("mpi_errno = %s(%s);" % (mpir_name, args))
dump_error_check("")
else:
# blocking collectives
dump_line_with_break("mpi_errno = %s(%s, 0);" % (mpir_name, args))
dump_error_check("")

def dump_coll_v_swap(func):
# -- wrappers to make code cleaner
def replace_arg(old, new):
Expand Down Expand Up @@ -2064,8 +2033,6 @@ def dump_body_normal():
dump_body_topo_fns(func, RE.m.group(1))
else:
print("Error: unhandled special impl: [%s]" % func['impl'])
elif func['dir'] == 'coll':
dump_body_coll(func)
else:
dump_body_impl(func, "mpir")

Expand Down
213 changes: 0 additions & 213 deletions maint/tuning/coll/ch4/generic.json

This file was deleted.

48 changes: 0 additions & 48 deletions maint/tuning/coll/ch4/posix_generic.json

This file was deleted.

Loading