Skip to content
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
47 commits
Select commit Hold shift + click to select a range
f01f8b2
mpit: fix an unused function warning
hzhou Sep 4, 2025
cfdef4a
ADI: remove MPID collectives
hzhou Aug 22, 2025
7ca9a63
maint: move json_gen.sh to top of maint folder
hzhou Aug 25, 2025
64598d4
ch4/coll: remove device-layer json selections
hzhou Aug 22, 2025
50c0306
ch4: disable the code that call netmod/shm collectives
hzhou Aug 23, 2025
39b626d
ch4/api: remove netmod/shm collective api
hzhou Aug 22, 2025
6aa4bb2
ch4: remove device-layer json csel
hzhou Aug 24, 2025
c90c338
ch4/shm: inclusion order for shm_am.h
hzhou Aug 23, 2025
cdea774
all: use fallback routines for internal collectives
hzhou Aug 23, 2025
7eca0a9
ch3: use MPIR_Barrier_fallback internally
hzhou Sep 4, 2025
f467a76
temp auto
hzhou Sep 4, 2025
fcd72ba
coll: remove fallback in collective algorithm
hzhou Aug 23, 2025
3d3d902
coll/prep: just use fallback in tsp auto functions
hzhou Aug 25, 2025
758fad6
coll/prep: remove the optional json search for parameters
hzhou Aug 25, 2025
2dfe0fc
coll/prep: call MPIR collectives in compositional algorithms
hzhou Aug 23, 2025
8ec926c
coll/csel: rename coll_info to coll_sig
hzhou Aug 19, 2025
ca84b21
coll/csel: pass coll_sig by pointer
hzhou Aug 21, 2025
ffb3a91
coll/csel: merge csel_container.h into mpir_csel.h
hzhou Aug 21, 2025
a86f92b
coll: add coll_composition.json and coll_selection.json
hzhou Aug 21, 2025
ac28fb3
coll: add MPIR_Coll_auto and MPIR_Composition_auto
hzhou Aug 21, 2025
b286fdc
coll: add MPIR_Coll_nb
hzhou Aug 24, 2025
387fbe7
coll: remove all allcomm_nb algorithms
hzhou Sep 4, 2025
b498b79
coll: add abstract coll algo interface and auto functions
hzhou Aug 21, 2025
c71941f
coll/gen_coll: dump algo functions
hzhou Aug 22, 2025
613c846
coll/python: generate impl functions
hzhou Aug 22, 2025
d2b447f
coll/gen_coll: temporarily generate MPIR collectives
hzhou Aug 23, 2025
a3aaf2e
misc: only include json.h where needed
hzhou Aug 24, 2025
f4bf49d
coll: reorganize csel headers
hzhou Aug 24, 2025
0d711b0
coll/csel: remove MPIR_Csel_prune
hzhou Sep 2, 2025
95a323b
coll/gen_coll: generate algorithm container ids
hzhou Aug 24, 2025
35a127f
misc: spelling check
hzhou Aug 25, 2025
e38853a
coll: remove the alias feature in coll_algorithms.txt
hzhou Aug 24, 2025
d167949
coll: remove MPIR_Csel_root
hzhou Aug 25, 2025
5e51766
coll/csel: new coll_algorithms.txt
hzhou Sep 4, 2025
6f485a2
coll/csel: new coll_selection.json
hzhou Sep 4, 2025
d474db5
coll/gen: update gen_coll.py
hzhou Sep 5, 2025
f18f3e3
ADI/csel: add hooks for initializing coll_sig
hzhou Aug 28, 2025
bba499e
coll/csel: update csel
hzhou Aug 24, 2025
12f3f8a
---- START HERE ----
hzhou Sep 25, 2025
3aa7619
TEMP: fixup coll/csel: update csel
hzhou Sep 25, 2025
78a8b7d
coll/gen_coll: add "inline" and "func_name" directives
hzhou Sep 26, 2025
58e0308
coll/gen_coll: add conditional condition
hzhou Sep 26, 2025
0307432
coll: add is_cvar to struct MPIR_Csel_coll_sig
hzhou Sep 25, 2025
f949b6b
coll: add coll_sig->flags for boolean flags
hzhou Sep 25, 2025
20eb0bd
coll: add MPIR_CVAR_DUMP_COLL_ALGO_COUNTERS
hzhou Sep 25, 2025
6c28e11
coll/ch4: activate CH4 POSIX release_gather bcast
hzhou Sep 25, 2025
9db1880
coll/ch4: activate release_gather for reduce/allreduce/barrier
hzhou Sep 26, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion autogen.sh
Original file line number Diff line number Diff line change
Expand Up @@ -531,7 +531,7 @@ fn_gen_binding_c() {

fn_json_gen() {
echo_n "generating json char arrays... "
./maint/tuning/coll/json_gen.sh
./maint/json_gen.sh
echo "done"
}

Expand Down
1 change: 1 addition & 0 deletions dummy
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
1
1,426 changes: 861 additions & 565 deletions maint/gen_coll.py

Large diffs are not rendered by default.

5 changes: 2 additions & 3 deletions maint/tuning/coll/json_gen.sh → maint/json_gen.sh
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,5 @@ cat > $cfile<<EOF
EOF

# create specific json buffers
create_json_buf maint/tuning/coll/mpir/generic.json MPII_coll_generic_json
create_json_buf maint/tuning/coll/ch4/generic.json MPIDI_coll_generic_json
create_json_buf maint/tuning/coll/ch4/posix_generic.json MPIDI_POSIX_coll_generic_json
create_json_buf src/mpi/coll/coll_composition.json MPII_coll_composition_json
create_json_buf src/mpi/coll/coll_selection.json MPII_coll_selection_json
33 changes: 0 additions & 33 deletions maint/local_python/binding_c.py
Original file line number Diff line number Diff line change
Expand Up @@ -1782,17 +1782,9 @@ def push_impl_decl(func, impl_name=None):

if func['_impl_param_list']:
params = ', '.join(func['_impl_param_list'])
if func['dir'] == 'coll':
# block collective use an extra coll_attr
if not RE.match(r'MPI_(I.*|Neighbor.*|.*_init)$', func['name']):
params = params + ", int coll_attr"
else:
params="void"

if func['dir'] == 'coll':
# collective also dump MPIR_Xxx(...)
mpir_name = re.sub(r'^MPIX?_', 'MPIR_', func['name'])
G.impl_declares.append("int %s(%s);" % (mpir_name, params))
# dump MPIR_Xxx_impl(...)
if func['dir'] == 'io':
G.io_impl_declares.append("int %s(%s);" % (impl_name, params))
Expand Down Expand Up @@ -1821,29 +1813,6 @@ def dump_CHECKENUM(var, errname, t, type="ENUM"):
G.out.append("goto fn_fail;")
dump_if_close()

def dump_body_coll(func):
# collectives call MPIR_Xxx
mpir_name = re.sub(r'^MPIX?_', 'MPIR_', func['name'])

args = ", ".join(func['_impl_arg_list'])

if RE.match(r'MPI_(I.*|.*_init)$', func['name'], re.IGNORECASE):
# non-blocking collectives
G.out.append("MPIR_Request *request_ptr = NULL;")
dump_line_with_break("mpi_errno = %s(%s);" % (mpir_name, args))
dump_error_check("")
G.out.append("if (!request_ptr) {")
G.out.append(" request_ptr = MPIR_Request_create_complete(MPIR_REQUEST_KIND__COLL);")
G.out.append("}")
G.out.append("*request = request_ptr->handle;")
elif RE.match(r'mpi_neighbor_', func['name'], re.IGNORECASE):
dump_line_with_break("mpi_errno = %s(%s);" % (mpir_name, args))
dump_error_check("")
else:
# blocking collectives
dump_line_with_break("mpi_errno = %s(%s, 0);" % (mpir_name, args))
dump_error_check("")

def dump_coll_v_swap(func):
# -- wrappers to make code cleaner
def replace_arg(old, new):
Expand Down Expand Up @@ -2064,8 +2033,6 @@ def dump_body_normal():
dump_body_topo_fns(func, RE.m.group(1))
else:
print("Error: unhandled special impl: [%s]" % func['impl'])
elif func['dir'] == 'coll':
dump_body_coll(func)
else:
dump_body_impl(func, "mpir")

Expand Down
213 changes: 0 additions & 213 deletions maint/tuning/coll/ch4/generic.json

This file was deleted.

48 changes: 0 additions & 48 deletions maint/tuning/coll/ch4/posix_generic.json

This file was deleted.

Loading